Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/chromadb #131

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Patch/chromadb #131

merged 4 commits into from
Dec 3, 2024

Conversation

lazToum
Copy link
Collaborator

@lazToum lazToum commented Dec 2, 2024

We currently expect a ValueError when calling client.get_collection .
However, we might get a chromadb.errors.ChromaError (at least in recent chromadb versions: https://github.com/chroma-core/chroma/blob/main/chromadb/api/segment.py#L300.

Why are these changes needed?

Related issue number

Checks

Copy link
Collaborator

@marklysze marklysze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @lazToum! LGTM

@marklysze marklysze added this pull request to the merge queue Dec 3, 2024
Merged via the queue into main with commit 47f6b71 Dec 3, 2024
214 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants