Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict license checks to staged/committed files only #106

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

marklysze
Copy link
Collaborator

Why are these changes needed?

In my previous implementation of the license check, #90, when running the check locally with pre-commit run it would check all python files, irrespective of whether they were staged or not.

This update fixes that.

Also, when this runs as a GitHub action it will check against the base branch.

Related issue number

N/A

Checks

@marklysze marklysze added the bug Something isn't working label Nov 28, 2024
Copy link
Collaborator

@qingyun-wu qingyun-wu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks1

@qingyun-wu
Copy link
Collaborator

There is code formating problem.

@marklysze
Copy link
Collaborator Author

There is code formatting problem.

Yep, thanks - let me make sure it goes through as the code covers both local use and GitHub action use - so need to make sure it's working in GitHub too :)

@marklysze marklysze requested a review from qingyun-wu November 28, 2024 03:51
@marklysze
Copy link
Collaborator Author

Okay, passed!

@qingyun-wu qingyun-wu added this pull request to the merge queue Nov 28, 2024
Merged via the queue into main with commit 35b7119 Nov 28, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants