Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returntoloop #18

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Returntoloop #18

wants to merge 5 commits into from

Conversation

kristinrma
Copy link

in startupdatingcallbackwithposition(), added condition to return to loop start if curr reaches the end of song

Copy link
Collaborator

@howardwang00 howardwang00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current implementation has a race condition, where the looping check and the end of song check are competing. When I pause the music, drag the seekbar to the end, then set the end loop, half of the time it goes to the start marker, and otherwise it just restarts the song. I think we need to look at where it restarts the song itself and add that edge case there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants