Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AYS-500 | Fixed the time and user were not being updated in the role update #386

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

MenekseYuncu
Copy link
Contributor

Checklist

Before submitting your pull request, ensure the following:

  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have tested my changes locally on Postman, and they are working as expected.
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by SonarLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated, specifically detailing changes made in Postman.
  • Testing:

    • Relevant unit tests have been written and included.
    • Relevant integration tests have been written and included.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.
    • Assignees have been added if necessary.
  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.

@MenekseYuncu MenekseYuncu requested a review from a team October 8, 2024 12:19
@MenekseYuncu MenekseYuncu self-assigned this Oct 8, 2024
@MenekseYuncu MenekseYuncu changed the title AYS-500 | Time and user not being updated has been fixed AYS-500 | Fixed the time and user were not being updated in the role update Oct 8, 2024
@agitrubard
Copy link
Collaborator

agitrubard commented Oct 8, 2024

@MenekseYuncu reviewer eklerken @afet-yonetim-sistemi/back-end ekibini değil de, doğrudan kişileri ekleyebilir miyiz? Bu sayede doğrudan bildirim gidiyor olur. Bu şekilde kullandığımızda bir kişi bile approve'lasa ilgili label kalktığı için çok kullanışlı olmuyor. Bizim isteğimiz mümkün olduğunda bütün herkesin review sürecine dahil olması üzerine.


Bkz. ben review ettikten sonra artık kayboldu :/
image

@agitrubard agitrubard merged commit 0445c7e into main Oct 14, 2024
1 check passed
@agitrubard agitrubard deleted the AYS-500/role-update-updatedat branch October 14, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants