-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many UI fixes #17
Open
jhallen
wants to merge
15
commits into
afarhan:master
Choose a base branch
from
jhallen:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Many UI fixes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminate slow display, make knob fast and responsive Rework acceleration logic Make fast tune a mode instead of a command (so it cancels if user tries another command) Fix command text alignment Land only on detents, never half-way Fix focus logic, white square means focus, white text means selected VFO Fix focus crash bug from uninitialized variable Menu selection moves one per detent, not one every 5
…e most text background is set to navy (alternative would be to set all setup text backgound to black..)
…d in Arduino IDE without fuss.
…ommon VFO buffer). Don't allow fast tune mode when RIT is on. Fix some more text alignment bugs.. now there is an alignment arguments for drawText so that it can be used in more cases. Add defines for main screen layout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry that this includes multiple fixes, it's basically a UI cleanup.
This includes:
Immediate PLL change when pressing USB / LSB buttons
Fix crashing bug when entering menu (due to uninitialized variable)
Tuning knob improvement: only register detents, not half-way points
Tuning knob improvement: Improve tuning speed and display update rate. This was almost all there with the interrupt driven encoder code, but needed some final cleanup to get it to be really smooth.
-Tuning knob improvement: Simplify knob "momentum" code: now the tuning jumps at fast rate if you have been turning the knob fast for a while.
Tuning knob improvement: now each detent causes a focus change, not one out of 10. With the above half-way fix, this works really well.
Fix some text alignment issues: buttons were being erased
Fix some focus related issues: now selected VFO is indicated by white text, and white outline only means focus. So now when you press tuning button you get immediate feedback.