Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null safety migration #117

Merged
merged 5 commits into from
Jul 2, 2021
Merged

Null safety migration #117

merged 5 commits into from
Jul 2, 2021

Conversation

enzoftware
Copy link
Contributor

This PR is trying to solve #116 and made the package suitable with Flutter 2.0. 🚀

Updated dependencies

  • min sdk: >=2.12.0
  • intl from ^0.16.0 to ^0.17.0

Testing

  • ✅ Unit testing passed
  • ✅ Example running on Android, iOS, and Chrome 🕸️

Any suggestion is welcome! 🍻

diegoveloper
diegoveloper approved these changes Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@diegoveloper diegoveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@diegoveloper diegoveloper merged commit 30d582e into aeyrium:master Jul 2, 2021
Raunakk02
Raunakk02 reviewed Jul 2, 2021
View reviewed changes
Copy link

@Raunakk02 Raunakk02 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!
I wanted to use this package in my project, but since it was null unsafe, I could not do so.
But after these changes, I will be able to use them in my project. 😃

But on pub.dev it's still not showing that this package is null-safe! 🤔

@calvintam236 calvintam236 mentioned this pull request Jul 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raunakk02 Raunakk02 Raunakk02 left review comments

@diegoveloper diegoveloper diegoveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@enzoftware @diegoveloper @Raunakk02