Add CompilerCli #1725
Merged
Add CompilerCli #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Methods of `CompilerHttp` moved to `api` property
Apply a patch:
```diff
-compilerHttp.generateACI({ code: sourceCode });
+compilerHttp.api.generateACI({ code: sourceCode });
```
BREAKING CHANGE: `createGeneralizedAccount` accepts `sourceCode` in options
Apply a patch:
```diff
-aeSdk.createGeneralizedAccount('authorize', sourceCode, ['arg-1']);
+aeSdk.createGeneralizedAccount('authorize', ['arg-1'], { sourceCode });
```
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
davidyuk
force-pushed
the
feature/compiler-cli
branch
3 times, most recently
from
12cf236 to
58f8b1b
Compare
Codecov ReportBase: 84.34% // Head: 82.28% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1725 +/- ##
===========================================
- Coverage 84.34% 82.28% -2.07%
===========================================
Files 70 74 +4
Lines 2913 2862 -51
Branches 509 547 +38
===========================================
- Hits 2457 2355 -102
+ Misses 251 244 -7
- Partials 205 263 +58
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
davidyuk
force-pushed
the
feature/compiler-cli
branch
from
58f8b1b to
de56cbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1693
found issues aeternity/aesophia#443 aeternity/aesophia#444 aeternity/aesophia_cli#73 aeternity/aesophia_cli#74 aeternity/aesophia_cli#75
This PR is supported by the Æternity Crypto Foundation