Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go Client v7.6.0 #444

Merged
merged 15 commits into from
Jul 22, 2024
Merged

Go Client v7.6.0 #444

merged 15 commits into from
Jul 22, 2024

Conversation

khaf
Copy link
Collaborator

@khaf khaf commented Jul 17, 2024

Don't merge yet

khaf and others added 10 commits July 1, 2024 17:46
@khaf
[CLIENT-3022] Close() throws a nil point error on ProxyClient without…
df5bcf4 
… Authentication
@khaf
Update CHANGELOG
8c8c1a6
@reugn
[CLIENT-3044] Resolve memory leak caused by circular reference in cli…
f2b691d 
…ent finalizer (#441)
@khaf
[CLIENT-3045] Move proxy client build behind a build flag
57c4f2b 
This removes the GRPC compilation and potential namespace conflict from the default build and moves it behind the compiler build flag "as_proxy"
@khaf
Update CHANGELOG
012cf10
@khaf
Update dependencies
35c6409
@reugn
[CLIENT-3047] Fix pointer value assignment in baseMultiCommand.parseK…
90cbef5 
…ey (#443)
@reugn
[CLIENT-3048] Use precomputed ops variable in batchIndexCommandGet.ex…
04acf53 
…ecuteSingle (#442)
@khaf
Update CHANGELOG
7b8b7fe
@khaf
[CLIENT-3046] Wrong return type in Single Key Batch Operations with M…
be575a3 
…ultiple Ops per Bin
justinlee-aerospike
justinlee-aerospike previously approved these changes Jul 17, 2024
View reviewed changes
Copy link

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

README.md Outdated Show resolved Hide resolved
justinlee-aerospike
justinlee-aerospike previously approved these changes Jul 18, 2024
View reviewed changes
Copy link

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good

@khaf
[CLIENT-3049] Use a specialized pool for grpc conns to prevent premat…
fee6173 
…ure reaping

Also fixes namespace parameter for a few code examples.
justinlee-aerospike
justinlee-aerospike previously approved these changes Jul 19, 2024
View reviewed changes
Copy link

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good

justinlee-aerospike
justinlee-aerospike approved these changes Jul 22, 2024
View reviewed changes
Copy link

@justinlee-aerospike justinlee-aerospike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new changes look good

@khaf khaf merged commit 4e58b27 into v7 Jul 22, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinlee-aerospike justinlee-aerospike justinlee-aerospike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khaf @justinlee-aerospike @reugn