Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

feat(core) : Upgraded to angular v16 and added angular-eslint #19

Merged
merged 9 commits into from
Oct 13, 2023

Conversation

TheoDurr
Copy link

Here are the things I've done on this branch :

  • Upgraded to angular v16
  • Added angular-eslint as eslint config
  • Edited angular config to add sith prefix in front of each component
  • Specified node requirement to node 18 at least

@Juknum Juknum self-requested a review October 13, 2023 11:55
@Juknum
Copy link
Member

Juknum commented Oct 13, 2023

Nice PR, can you modify the .editorconfig to match the one from the API? (I've seen mixed tabs/spaces in your JSON file 👀)

@TheoDurr
Copy link
Author

@Juknum which json file ? Also, VSCode is intended to use the prettier config in .prettierrc to do its formatting

@TheoDurr
Copy link
Author

Ok, fixed everything. The editor config is the identical to the api's one. I've also edited the script for prettier to format all files apart from the ones specified in .prettierignore.

@TheoDurr TheoDurr self-assigned this Oct 13, 2023
@Juknum Juknum merged commit 3c153ee into develop Oct 13, 2023
2 checks passed
@Juknum Juknum deleted the features/angular-16-upgrade branch October 13, 2023 20:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants