Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make counter click client side first #959

Merged
merged 32 commits into from
Dec 27, 2024
Merged

Make counter click client side first #959

merged 32 commits into from
Dec 27, 2024

Conversation

klmp200
Copy link
Contributor

@klmp200 klmp200 commented Dec 20, 2024

Bon alors là c'est LE gros rework des comptoirs.
J'ai converti tout l'ancien code du backend pour quelque chose de frontend first où on envoi toute la commande d'un coup.

Ça simplifie énormément le code du backend et ça devrais fluidifier largement les transactions.

@klmp200 klmp200 force-pushed the counter-click-step-4 branch from 79973a0 to 3c32317 Compare December 20, 2024 16:59
@klmp200 klmp200 force-pushed the counter-click-step-3 branch from ddcb2d8 to 4ac09ac Compare December 21, 2024 14:56
Base automatically changed from counter-click-step-3 to taiste December 21, 2024 15:00
@klmp200 klmp200 force-pushed the counter-click-step-4 branch 3 times, most recently from 1bbaea0 to ff475c2 Compare December 22, 2024 00:59
imperosol
imperosol reviewed Dec 22, 2024
View reviewed changes
Copy link
Contributor

@imperosol imperosol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est encore en draft, et on a déjà discuté de l'architecture générale, donc je fais juste quelques commentaires en passant.

counter/models.py Show resolved Hide resolved
counter/static/bundled/counter/counter-click-index.ts Outdated Show resolved Hide resolved
counter/static/bundled/counter/counter-click-index.ts Outdated Show resolved Hide resolved
counter/templates/counter/counter_click.jinja Show resolved Hide resolved
counter/views/click.py Show resolved Hide resolved
counter/views/click.py Outdated Show resolved Hide resolved
counter/views/click.py Show resolved Hide resolved
counter/views/click.py Outdated Show resolved Hide resolved
counter/views/click.py Outdated Show resolved Hide resolved
counter/views/click.py Outdated Show resolved Hide resolved
klmp200 added 13 commits December 22, 2024 12:06
@klmp200
Make counter click client side first
60f1866
@klmp200
Don't use codes as a primary key in counter click
a383f3e
@klmp200
Fix counter main
a548f47 
* Fix crash when submitting nothing
* Fix code field not being autofocus
@klmp200
Fix crash during validation
8ebea00
@klmp200
Restore form when form submit fails due to error
f9d7dc7
@klmp200
Properly display form errors in counter
5f0b4d2
@klmp200
Redirect when cancelling instead of submitting a form
ffe6fc8
@klmp200
Fix customerBalance not init and submit/cancel buttons visuals
ccf5767
@klmp200
Display nice product cards on counter click interface
c37288c
@klmp200
Pre-filter allowed products in backend for counter click
eea237b
@klmp200
Optimize product id validation on counter click
7071553
@klmp200
Improve empty basket and tray price management
372470b
@klmp200
Improve age management for getting products and make get_product a pa…
eed434a 
…rt of counter model
@klmp200 klmp200 force-pushed the counter-click-step-4 branch from 73bb53b to eed434a Compare December 22, 2024 11:28
@klmp200 klmp200 marked this pull request as ready for review December 23, 2024 01:26
@klmp200 klmp200 requested a review from imperosol December 23, 2024 01:26
imperosol
imperosol reviewed Dec 23, 2024
View reviewed changes
counter/models.py Show resolved Hide resolved
counter/static/bundled/counter/counter-click-index.ts Outdated Show resolved Hide resolved
counter/tests/test_counter.py Outdated Show resolved Hide resolved
counter/tests/test_counter.py Outdated Show resolved Hide resolved
counter/tests/test_counter.py Outdated Show resolved Hide resolved
counter/tests/test_counter.py Outdated Show resolved Hide resolved
imperosol
imperosol reviewed Dec 25, 2024
View reviewed changes
counter/templates/counter/counter_click.jinja Outdated Show resolved Hide resolved
counter/templates/counter/counter_click.jinja Outdated Show resolved Hide resolved
core/static/core/style.scss Outdated Show resolved Hide resolved
@klmp200 klmp200 requested a review from imperosol December 26, 2024 10:52
@klmp200 klmp200 merged commit 11702d3 into taiste Dec 27, 2024
3 checks passed
@klmp200 klmp200 deleted the counter-click-step-4 branch December 27, 2024 21:06
This was referenced Dec 30, 2024
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imperosol imperosol imperosol approved these changes

@Hyask Hyask Awaiting requested review from Hyask

@NaNoMelo NaNoMelo Awaiting requested review from NaNoMelo

Assignees

@klmp200 klmp200

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klmp200 @imperosol