Add tests for user preferences #950
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…accessing trombi user
imperosol
requested changes
Dec 16, 2024
Comment on lines
+196
to
+293
| @pytest.mark.django_db | ||
| class TestUserPreferences: | ||
| @pytest.fixture | ||
| def subscriber(self) -> User: | ||
| return subscriber_user.make() | ||
|
|
||
| @pytest.fixture | ||
| def other_subscriber(self) -> User: | ||
| return subscriber_user.make() | ||
|
|
||
| @pytest.fixture | ||
| def trombi_user(self) -> User: | ||
| user = subscriber_user.make() | ||
| club = baker.make(Club) | ||
| baker.make( | ||
| Membership, | ||
| club=club, | ||
| start_date=now() - timedelta(days=30), | ||
| role=settings.SITH_CLUB_ROLES_ID["Curious"], | ||
| user=user, | ||
| ) | ||
| trombi = baker.make(Trombi, club=club) | ||
| baker.make(TrombiUser, user=user, trombi=trombi) | ||
| return user | ||
|
|
||
| @pytest.fixture | ||
| def non_subscriber(self) -> User: | ||
| return baker.make(User) | ||
|
|
||
| @pytest.fixture | ||
| def club_admin(self) -> User: | ||
| user = baker.make(User) | ||
| baker.make( | ||
| Membership, | ||
| start_date=now() - timedelta(days=30), | ||
| role=settings.SITH_CLUB_ROLES_ID["Board member"], | ||
| user=user, | ||
| ) | ||
| return user | ||
|
|
||
| @pytest.fixture | ||
| def board_member(self) -> User: | ||
| return board_user.make() | ||
|
|
||
| @pytest.fixture | ||
| def admin(self) -> User: | ||
| return baker.make(User, is_superuser=True) | ||
|
|
||
| @pytest.mark.parametrize( | ||
| ("tested_user", "accessing_user", "expected_code"), | ||
| [ | ||
| ("subscriber", None, 403), # Anonymous user | ||
| ("subscriber", "non_subscriber", 403), | ||
| ("subscriber", "club_admin", 403), | ||
| ("subscriber", "other_subscriber", 403), | ||
| ("subscriber", "trombi_user", 403), | ||
| ("subscriber", "subscriber", 200), | ||
| ("subscriber", "board_member", 200), | ||
| ("subscriber", "admin", 200), | ||
| ("non_subscriber", None, 403), # Anonymous user | ||
| ("non_subscriber", "club_admin", 403), | ||
| ("non_subscriber", "subscriber", 403), | ||
| ("non_subscriber", "other_subscriber", 403), | ||
| ("non_subscriber", "trombi_user", 403), | ||
| ("non_subscriber", "non_subscriber", 200), | ||
| ("non_subscriber", "board_member", 200), | ||
| ("non_subscriber", "admin", 200), | ||
| ("trombi_user", None, 403), # Anonymous user | ||
| ("trombi_user", "club_admin", 403), | ||
| ("trombi_user", "subscriber", 403), | ||
| ("trombi_user", "other_subscriber", 403), | ||
| ("trombi_user", "non_subscriber", 403), | ||
| ("trombi_user", "trombi_user", 200), | ||
| ("trombi_user", "board_member", 200), | ||
| ("trombi_user", "admin", 200), | ||
| ], | ||
| ) | ||
| @pytest.mark.django_db | ||
| def test_user_preferences_access( | ||
| self, | ||
| client: Client, | ||
| request: pytest.FixtureRequest, | ||
| tested_user: str, | ||
| accessing_user: str | None, | ||
| expected_code: int, | ||
| ): | ||
| cache.clear() | ||
| if accessing_user is not None: | ||
| client.force_login(request.getfixturevalue(accessing_user)) | ||
| assert ( | ||
| client.get( | ||
| reverse( | ||
| "core:user_prefs", | ||
| kwargs={"user_id": request.getfixturevalue(tested_user).pk}, | ||
| ) | ||
| ).status_code | ||
| == expected_code | ||
| ) |
There was a problem hiding this comment.
Tu utilises un seul test pour tester trois choses distinctes (accès à ses préférences, accès aux préférences d'un autre utilisateur, accès aux préférence d'un utilisateur appartenant à un trombi).
Ca fait que tu balances pas mal de boilerplate et de techniques qui devraient relever plus de l'exception que de la manière générale d'écrire des tests. Au final, ça fait pas mal de code pour quelque chose dont on ne comprend pas exactement ce que c'est censé tester.
Tu ne veux pas découper ça en trois tests distincts et un peu plus simples ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.