User model #929
Merged
User model #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klmp200
reviewed
Nov 21, 2024
core/migrations/0040_alter_user_options_user_user_permissions_and_more.py
Show resolved
Hide resolved
Hyask
reviewed
Nov 26, 2024
imperosol
force-pushed
the
user-model
branch
from
1934db0 to
05d23cc
Compare
imperosol
force-pushed
the
user-model
branch
2 times, most recently
from
3fcc460 to
aaaa225
Compare
imperosol
force-pushed
the
user-model
branch
3 times, most recently
from
8d8ba1a to
5b361c9
Compare
imperosol
force-pushed
the
user-model
branch
from
5b361c9 to
a7b1406
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Habituellement, le changement de modèle User par défaut se fait en héritant d'
AbstractUser(qui hérite lui-même d'AbstractBaseUseret dePermissionMixin), mais notre modèle hérite d'AbstractBaseUser. On perd donc lePermissionMixin. Ca nous place en grosse partie hors des clous du système d'auth de django. Et c'est vraiment chiant à gérer.L'idée initiale était de remplacer le système de permissions de Django, plutôt que de construire quelque chose en plus. Ca se voit, d'ailleurs. Notre modèle User est une grosse duplication d'AbstractUser ; il hérite juste pas de PermissionMixin.
Eh bah bilan, l'idée était pas terrible. Notre propre interface est pas toujours respectée (sérieusement, regardez-moi le foutoir des permissions de la table des clubs). Et la vérification des droits n'est pas très efficace, voire est carrément inefficace (O(n) sur des ListView, tmtc).
Bref, on va tenter de se remettre sur les rails. Et pour commencer ça, on va revenir sur
AbstractUser.C'est juste la toute première étape, mais c'est déjà un gros truc. D'autres PRs suivront pour la refonte du système de perms.