-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sith compatible with windows #863
base: taiste
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -84,6 +84,8 @@ default-groups = ["dev", "tests", "docs"] | |
|
||
[tool.xapian] | ||
version = "1.4.25" | ||
core-sha1 = "e2b4b4cf6076873ec9402cab7b9a3b71dcf95e20" | ||
bindings-sha1 = "782f568d2ea3ca751c519a2814a35c7dc86df3a4" | ||
Comment on lines
+87
to
+88
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ca sera quoi, le processus pour changer les hashs ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Faut le faire manuellement quand tu upgrade, je pense qu'un tutoriel ce serait pas mal. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mets-le dans le tuto. Ca devrait suffire, je pense. Surtout que c'est pas quelque chose qu'on fait souvent. |
||
|
||
[tool.ruff] | ||
output-format = "concise" # makes ruff error logs easier to read | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Si tu utilises make, il faut rajouter dans la doc la manière d'installer ça sur Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alors justement, j'y suis pas encore
Là j'ai seulement fait la première étape : convertir le script
La seconde étape ce sera de télécharger mingw dans un dossier du projet quand t'es sur windows, histoire que tu puisse compiler sans devoir expliquer à quelqu'un c'est quoi un path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mouais. Je sais pas trop si c'est souhaitable d'installer mingw sans demander. Ca reste relativement pas trop douloureux à installer, mingw, donc en vrai fournir des instructions d'installation, ça me parait ok.
Mais bon, je te laisse faire, je regarde les idées que t'implémenteras.