Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

[FIX] Avoid unverified users to login #18

Merged
merged 1 commit into from
Oct 29, 2023
Merged

[FIX] Avoid unverified users to login #18

merged 1 commit into from
Oct 29, 2023

Conversation

Juknum
Copy link
Member

@Juknum Juknum commented Oct 29, 2023 •
edited
Loading

Changes

  • Added a verification step in AuthService.signIn(): if the user is not verified throw a ForbiddenException
  • Adapted logs e2e tests to use a verified user

Fixes

@Juknum Juknum requested review from TheoDurr and Nchrd October 29, 2023 16:13
@Juknum Juknum self-assigned this Oct 29, 2023
@Juknum Juknum added this to the v1.0.0 milestone Oct 29, 2023
@Juknum Juknum linked an issue Oct 29, 2023 that may be closed by this pull request
[BUG] Unverified users can still log-in #17
Closed
1 task
@Juknum Juknum merged commit 8501ac1 into develop Oct 29, 2023
5 checks passed
@Juknum Juknum deleted the bugfix/17-unverified-users-can-login branch October 29, 2023 17:16
@Juknum Juknum added status: approved The issue has been verified and is ready to be worked on type: enhancement Improvement of an existing feature, which can potentially change its operation type: bug The issue documents broken, incorrect, or confusing behavior and removed type: enhancement Improvement of an existing feature, which can potentially change its operation labels Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Nchrd Nchrd Nchrd approved these changes

@TheoDurr TheoDurr Awaiting requested review from TheoDurr

Assignees

@Juknum Juknum

Labels
status: approved The issue has been verified and is ready to be worked on type: bug The issue documents broken, incorrect, or confusing behavior
Projects
API
Status: 🌟 Deploy to prod
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

[BUG] Unverified users can still log-in
2 participants
@Juknum @Nchrd