Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links with images #101

Merged
merged 4 commits into from
Nov 18, 2023
Merged

Fix links with images #101

merged 4 commits into from
Nov 18, 2023

Conversation

roelofr
Copy link
Collaborator

@roelofr roelofr commented Nov 18, 2023

See #100, this adds backwards compatible fixes to the view.

@roelofr roelofr self-assigned this Nov 18, 2023
@roelofr roelofr force-pushed the fix/links-with-image-fix branch 2 times, most recently from 12b04da to 7a7951f Compare November 18, 2023 17:36
Supporting the "old" form too, since it may be used somehow.

Fixes #100
@roelofr roelofr force-pushed the fix/links-with-image-fix branch 5 times, most recently from 46c1fde to ffd9814 Compare November 18, 2023 18:15
@roelofr roelofr force-pushed the fix/links-with-image-fix branch from ffd9814 to 072d53a Compare November 18, 2023 18:17
@roelofr
Copy link
Collaborator Author

roelofr commented Nov 18, 2023

Wow, the required number of changes just to get this small fix through is intense.

Anyhow, this should do it.

@roelofr roelofr force-pushed the fix/links-with-image-fix branch from 8b72b66 to 37f758f Compare November 18, 2023 18:21
Copy link

Coverage Report

Totals Coverage
Statements: 82.36% ( 509 / 618 )
Methods: 32% ( 8 / 25 )
Lines: 84.49% ( 501 / 593 )

StandWithUkraine

@roelofr roelofr merged commit d4be2a2 into master Nov 18, 2023
13 checks passed
@roelofr roelofr deleted the fix/links-with-image-fix branch November 18, 2023 18:24
@tractorcow
Copy link

Thank you so much @roelofr , that fix looks perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants