Remove cartesian product in MkConstBindingPathComponentList

[lcartey]

We have observed performance issues in the UI5 queries related to bindings on databases with large amount of JSON (notably databases with significant numbers of CDS json file). Reviewing one such example, I observed the following slow predicates:

Most expensive predicates for completed query UI5Xss.ql:
        time  | evals |  max @ iter | predicate
        ------|-------|-------------|----------
        11.1s |     9 | 9.2s @ 1    | Bindings::BindingStringParser::MkConstBindingPathComponentList#dom#8f6dc5b2@f03adz6n
         9.2s |     6 | 7.1s @ 2    | num#Bindings::BindingStringParser::MkConstBindingPathComponentList#173021d1@f03adw6n
         8.5s |     2 | 6.9s @ 1    | Bindings::BindingStringParser::BindingPathComponentList.toString/0#2692bb01@49b354t2
         6.5s |     7 | 6.1s @ 3    | Bindings::BindingStringParser::MkConstBindingPathComponentList#173021d1#reorder_1_0_2_3@f03adx6n
         1.7s |     8 | 1.7s @ 4    | Bindings::BindingStringParser::mkBindingPathComponentList/3#6ec81d06#reorder_1_0_2@f03ady6n
         1.4s |     9 | 1.3s @ 4    | _Bindings::BindingStringParser::MkConstBindingPathComponentList#173021d1#reorder_1_0_2_3#prev_delta___#antijoin_rhs@L0#f03ad

Reviewing, the cause was that source was not bound within MkConstBindingPathComponentList.

    MkConstBindingPathComponentList(NameToken headToken, BindingPathComponentList tail, Token source) {
      exists(Token nextToken | nextToken = getNextSkippingWhitespace(headToken) |
        if nextToken instanceof ForwardSlashToken or nextToken instanceof DotToken
        then mkBindingPathComponentList(getNextSkippingWhitespace(nextToken), tail, _)
        else tail = MkEmptyBindingPathComponentList()
      )
    }

This was creating a cross-product with all source Tokens in the program (all tokens in potential binding paths).

As source was unused in any meaningful way outside the class itself, we can remove it without impact.

In addition, we can restrict the search for binding paths for XML and JSON files to those files which we actually consider to be views for UI5.

[knewbury01]

@lcartey need to address the testcase failures, thanks!

[knewbury01]

lgtm! thanks for the improvement