Merge pull request #76 from advanced-rest-client/fix/W-13536254/requi…

…red-fields [W-13536254] Required fields
advanced-rest-client · Jul 5, 2023 · ea17cd1 · ea17cd1
2 parents d95a9ea + 5506083
commit ea17cd1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@api-components/api-type-document",
   "description": "A documentation table for type (resource) properties. Works with AMF data model",
-  "version": "4.2.26",
+  "version": "4.2.27",
   "license": "Apache-2.0",
   "main": "index.js",
   "module": "index.js",

diff --git a/src/PropertyShapeDocument.js b/src/PropertyShapeDocument.js
@@ -390,6 +390,13 @@ export class PropertyShapeDocument extends PropertyDocumentMixin(LitElement) {
     return !!parentTypeName;
   }
 
+  _toBoolean(value) {
+    if (typeof value === 'boolean') {
+      return value
+    }
+    return value === 'true'
+  }
+
   /**
    * Computes value for `isRequired` property.
    * In AMF model a property is required when `http://www.w3.org/ns/shacl#minCount`
@@ -404,10 +411,11 @@ export class PropertyShapeDocument extends PropertyDocumentMixin(LitElement) {
     }
     shape = this._resolve(shape);
     if (this._hasType(shape, this.ns.aml.vocabularies.apiContract.Parameter)) {
-      return /** @type boolean */ Boolean(this._getValue(
+      const required = this._getValue(
         shape,
         this.ns.aml.vocabularies.apiContract.required
-      ));
+      )
+      return this._toBoolean(required);
     }
     const data = this._getValue(shape, this.ns.w3.shacl.minCount);
     return data !== undefined && Number(data) !== 0;