-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update/zabbix-api-params-changed-in-v6 #155
base: master
Are you sure you want to change the base?
Conversation
…6 and removed user.authenticate method that has been deprecated since version 2
…s-changed-in-v6 update/zabbix-api-params-changed-in-v6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great it this could be merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to break compatibility with previous versions. And it is used by many projects already.
I think we should keep both use_authenticate
and use_basic_auth
options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working
…endency update/add-required-dependency
This module does not work with Zabbix version 6 because they changed the user parameter in the user.login method. Added a version check to pass the correct params and removed user.authenticate method that has been deprecated since version 2.
https://www.zabbix.com/documentation/current/en/manual/api/reference/user/login
https://www.zabbix.com/documentation/2.0/en/manual/appendix/api/user/authenticate