Amend Windows Reproducible Ant Check To Be Less Strict #4092
+24
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested OK locally. |
github-actions
bot
added
the
windows
steelhead31
force-pushed
the
fix_issue_4062
branch
from
1f69127 to
14330bd
Compare
steelhead31
force-pushed
the
fix_issue_4062
branch
from
1c0e83d to
85726cc
Compare
sophia-guo
approved these changes
Dec 17, 2024
karianna
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4062
Update the ant validation logic in the windows reproducible build script to allow any minor version of the correct major version. Both are defined in the script header, 1.10.{X} will be treated as allowed, rather than pinning to the exact version in the SBOM.