Prevent jdk11+ from running external sign.sh as already signed during… #4083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… build Signed-off-by: Andrew Leonard <[email protected]>
github-actions
bot
added
jenkins
… build Signed-off-by: Andrew Leonard <[email protected]>
karianna
approved these changes
Dec 11, 2024
|
I'm looking forward to this being fixed in 24+27... Given two reviewers are required to merge this fix, assigning an additional reviewer would be a good thing. 😬 |
@merks hi, i'm hoping to get this merged today. I then need to do some separate work to build jdk24 which has now branched from mainstream jdk(head(25)) upstream, hopeful I can get that done in the next day too. |
|
sign_build tests jobs:
|
jerboaa
approved these changes
Dec 11, 2024
Co-authored-by: Severin Gehwolf <[email protected]>
jerboaa
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3997 and #4057
Eclipse Temurin jdk-11+ Windows & Mac signing is performed internally during the jmod build, if sign_build is called after the build, we end up with "duplicate" Signatures, and for jdk-24+ the JDK runtime is modified causing a runtime failure due to the new jlink runtime verification.
This PR ensure for Eclipse Temurin signing, only jdk8u signs everything, and for jdk-11+ ONLY Contents/MacOS/libjli.dylib is signed, which is the bundle executable entry point which has to be signed post-bundle build.