Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDXA XML and JSON support for temurin-build cyclonedx Java client #4063

Merged
merged 17 commits into from
Dec 3, 2024
Merged

CDXA XML and JSON support for temurin-build cyclonedx Java client #4063

merged 17 commits into from
Dec 3, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Nov 28, 2024 •
edited
Loading

Fixes #4050

  • Add new TemurinGenCDXA.java client to support generation of xml or json CDXA documents, as per content described Architect a "Verified Reproducible Build Attestation" Content #3950 (comment)
  • Add xml option to TemurinGenSBOM.java
  • Add cyclonedx-cli unit test SBOM validation to testsbom.yml github action
  • Remove incorrect and redundent addExternalReference() and addComponentExternalReference() client methods

@andrew-m-leonard andrew-m-leonard self-assigned this Nov 28, 2024
@andrew-m-leonard andrew-m-leonard marked this pull request as draft November 28, 2024 11:49
@github-actions github-actions bot added the testing Issues that enhance or fix our test suites label Nov 28, 2024
@andrew-m-leonard andrew-m-leonard marked this pull request as ready for review December 2, 2024 16:17
smlambert
smlambert approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@karianna karianna merged commit ededebc into adoptium:master Dec 3, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

@karianna karianna karianna approved these changes

@sxa sxa Awaiting requested review from sxa

Assignees

@andrew-m-leonard andrew-m-leonard

Labels
testing Issues that enhance or fix our test suites
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a temurin-build cycloneDX tooling CLI to create CDXA programmatically
3 participants
@andrew-m-leonard @karianna @smlambert