Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpine BusyBox mktemp does not support --directory #3638

Merged
merged 8 commits into from
Feb 7, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Feb 7, 2024

Fixes #3637

Alpine mktemp only support "-d" for directory not --directory
Also Alpine TEMPLATE has to have 6 X's !!
Also GNUPGHOME dir not created if path <83chars

Fixes #3636

@andrew-m-leonard andrew-m-leonard self-assigned this Feb 7, 2024
@github-actions github-actions bot added the alpine-linux Issues that affect or relate to the Alpine LINUX OS label Feb 7, 2024
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction to the code introduced by #3630

@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Feb 7, 2024

@andrew-m-leonard andrew-m-leonard mentioned this pull request Feb 7, 2024
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, couple of suggestions but take them or leave them as you wish :-)

build-farm/platform-specific-configurations/linux.sh Outdated Show resolved Hide resolved
Signed-off-by: Andrew Leonard <[email protected]>
@andrew-m-leonard
Copy link
Contributor Author

jdk11u CI failures are unrelated to this PR, and likely a github runner issue

@karianna karianna merged commit e4aa0c7 into adoptium:master Feb 7, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpine-linux Issues that affect or relate to the Alpine LINUX OS
Projects
None yet
3 participants