Exclude excessive build warnings on mac for jdk11 and jdk17 #3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also included some aggregate logic to avoid cflags overriding other cflags unintentionally Signed-off-by: Adam Farley <[email protected]>
github-actions
bot
added
macos
smlambert
approved these changes
Dec 12, 2023
sxa
reviewed
Dec 13, 2023
There was a problem hiding this comment.
Presumably the separation of c_flags_bucket and cxx_flags_bucket instead of just using one variable for this is due to the fact we're only adding the macosx-version-min parameter for C++? (Which is a bit surprising - I'd have thought we needed it on both, but that's not related to this PR!)
Other than the version check this LGTM.
sxa
approved these changes
Dec 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also included some aggregate logic to avoid cflags overriding other cflags unintentionally
Fixes #3562
JDK11 (includes fix) test run: https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-mac-aarch64-temurin/299/
JDK21 (excludes fix) test run: https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk21u/job/jdk21u-mac-aarch64-temurin/69/