-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add amount of disk space used by build to the log #3569
Conversation
run tests |
Looks like TKG is broken - unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run tests |
FYI to reviewers the new push is to fix quoting which was a mess so hopefully doesn't affect you're review :-) |
@sxa not sure why the checks are all failing.. |
See separate new issue referenced above for the GitHub check problems. |
Switching this to draft just now becuase it's not working. When I run |
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Rebasing to see if any of the actions failures fix themselves ... |
only the gpg failure on centos7 |
There are still a few issues in this area which I believe others are covering at the moment. On the basis that this PR is (hopefully clearly) not the cause of them I'm happy to merge this with those checks failing. |
This was user error on my part as I hadn't set the |
@andrew-m-leonard I'm going to merge this now since it has two approvers and your suggestions do not conflict with this. We can do a subsequent PR if you want to add the |
This will help log information that we can give to end users to tell how much space is required for builds, and also help with capacity planning on machines