Add --openjdk-target=x86_64-apple-darwin argument when crosscompiling jdk11+ (Mac) #3502
Conversation
github-actions
bot
added
macos
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
There was a problem hiding this comment.
If you haven't already done so I suggest running the change here and to the pipeline code through a test as described in https://github.com/adoptium/ci-jenkins-pipelines/wiki/Building-your-own-branch-of-ci-jenkins-pipelines-or-temurin-build so they are tested together before this gets merged.
|
jdk11 x64 mac build on build-macstadium-macos11-arm64-1 https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk11u/job/jdk11u-mac-x64-temurin/305/console
|
|
jdk17 x64 mac build on build-macstadium-macos11-arm64-2 https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk17u/job/jdk17u-mac-x64-temurin/374/console Again |
|
Kicked off a jdk8 x64 build on arm mac too https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-mac-x64-temurin/402/console |
|
The jdk11 linux, 17 linux and 11 dragonwell workflow failures are |
If this is happening consistently then we need an issue raised on it. |
|
/merge |
|
Approval to merge during the lockdown cycle Please can two Adoptium PMC members comment |
|
/approve |
1 similar comment
|
/approve |
github-actions
bot
dismissed
their stale review
Thank you @sxa and @andrew-m-leonard for your approvals, this pull request is now approved to merge during release.
Moving the if statement outside of the jdk8 only code will ensure that the
--openjdk-target=x86_64-apple-darwinconfig argument is added to the build command for all x64 jdks being built on arm64related adoptium/ci-jenkins-pipelines#825 and #3492