Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jdk-21 Windows builds to use MS VS2022 #3475

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Sep 7, 2023

jdk-21 Windows will use a latest MS VS2022 Installation.
Test build: https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk21/job/jdk21-windows-x64-temurin/77/

Updated .github/workflows/build.yml to support windows-2022 and vs2022 building.

@andrew-m-leonard andrew-m-leonard self-assigned this Sep 7, 2023
@github-actions github-actions bot added windows Issues that affect or relate to the WINDOWS OS testing Issues that enhance or fix our test suites labels Sep 7, 2023
@github-actions github-actions bot added testing Issues that enhance or fix our test suites and removed testing Issues that enhance or fix our test suites labels Sep 7, 2023
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-m-leonard andrew-m-leonard marked this pull request as draft September 8, 2023 10:43
@github-actions github-actions bot added testing Issues that enhance or fix our test suites and removed testing Issues that enhance or fix our test suites labels Sep 8, 2023
@andrew-m-leonard andrew-m-leonard marked this pull request as ready for review September 12, 2023 14:19
@github-actions github-actions bot added testing Issues that enhance or fix our test suites and removed testing Issues that enhance or fix our test suites labels Sep 12, 2023
@github-actions github-actions bot added testing Issues that enhance or fix our test suites and removed testing Issues that enhance or fix our test suites labels Sep 12, 2023
@github-actions github-actions bot added testing Issues that enhance or fix our test suites and removed testing Issues that enhance or fix our test suites labels Sep 12, 2023
@andrew-m-leonard andrew-m-leonard merged commit c8b16c2 into adoptium:master Sep 13, 2023
27 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issues that enhance or fix our test suites windows Issues that affect or relate to the WINDOWS OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants