Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add amount of disk space used by build to the log #3569

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Dec 9, 2023

This will help log information that we can give to end users to tell how much space is required for builds, and also help with capacity planning on machines

@sxa sxa self-assigned this Dec 9, 2023
@github-actions github-actions bot added jenkins Issues that enhance or fix our jenkins server macos Issues that affect or relate to the MAC OS labels Dec 9, 2023
@sxa sxa force-pushed the workspace_space branch from 2b13d1c to 1d30d8e Compare December 9, 2023 10:57
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Dec 9, 2023
@sxa sxa force-pushed the workspace_space branch from 1d30d8e to 95dc8ed Compare December 9, 2023 10:58
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Dec 9, 2023
@sxa sxa force-pushed the workspace_space branch from 95dc8ed to 388a3f0 Compare December 9, 2023 10:58
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Dec 9, 2023
@sxa sxa force-pushed the workspace_space branch from 388a3f0 to 98b4ee1 Compare December 9, 2023 11:01
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Dec 9, 2023
@sxa sxa force-pushed the workspace_space branch from 98b4ee1 to c415910 Compare December 9, 2023 11:05
@github-actions github-actions bot added macos Issues that affect or relate to the MAC OS and removed macos Issues that affect or relate to the MAC OS labels Dec 9, 2023
@sxa
Copy link
Member Author

sxa commented Dec 9, 2023

run tests

@karianna
Copy link
Contributor

Looks like TKG is broken - unrelated

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxa
Copy link
Member Author

sxa commented Feb 6, 2024

run tests

@sxa sxa force-pushed the workspace_space branch from 6fe2017 to c49d950 Compare February 6, 2024 16:07
@sxa
Copy link
Member Author

sxa commented Feb 6, 2024

FYI to reviewers the new push is to fix quoting which was a mess so hopefully doesn't affect you're review :-)

@karianna
Copy link
Contributor

karianna commented Feb 7, 2024

@sxa not sure why the checks are all failing..

@sxa
Copy link
Member Author

sxa commented Feb 7, 2024

See separate new issue referenced above for the GitHub check problems.

@sxa
Copy link
Member Author

sxa commented Feb 7, 2024

Switching this to draft just now becuase it's not working. When I run make-adopt-build-farm it gets to the end of build.sh and then stops after build.sh : 09:56:13 : All done! so it's not falling back to this script - maybe the result of an exec somewhere? Another commit will be required for this to work as expected (Or it could potentially be moved into build.sh however it's more for our infrastructure's benefit so this feels like the right place for it)

@sxa sxa force-pushed the workspace_space branch from 7a0a98c to b231350 Compare February 7, 2024 10:06
@sxa
Copy link
Member Author

sxa commented Feb 7, 2024

Rebasing to see if any of the actions failures fix themselves ...

@sxa sxa marked this pull request as draft February 7, 2024 10:07
@karianna
Copy link
Contributor

karianna commented Feb 7, 2024

only the gpg failure on centos7

@sxa sxa marked this pull request as ready for review February 8, 2024 11:31
@sxa
Copy link
Member Author

sxa commented Feb 8, 2024

only the gpg failure on centos7

There are still a few issues in this area which I believe others are covering at the moment. On the basis that this PR is (hopefully clearly) not the cause of them I'm happy to merge this with those checks failing.

@sxa
Copy link
Member Author

sxa commented Feb 8, 2024

Switching this to draft just now becuase it's not working. When I run make-adopt-build-farm it gets to the end of build.sh and then stops after build.sh : 09:56:13 : All done! so it's not falling back to this script - maybe the result of an exec somewhere?

This was user error on my part as I hadn't set the WORKSPACE directory before running my local test. It is working as expected. IMHO this is good to merge (@andrew-m-leonard if you're ok to approve given my earlier response to you that would be appreciated.

@sxa sxa requested a review from andrew-m-leonard February 8, 2024 12:09
@sxa
Copy link
Member Author

sxa commented Feb 8, 2024

@andrew-m-leonard I'm going to merge this now since it has two approvers and your suggestions do not conflict with this. We can do a subsequent PR if you want to add the df somewhere.

@sxa sxa merged commit fa3b1df into adoptium:master Feb 8, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins Issues that enhance or fix our jenkins server macos Issues that affect or relate to the MAC OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants