UnixPB: Add Docker Overlay Check Plugin Script For Nagios #3825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sxa
reviewed
Nov 27, 2024
...DK_Unix_Playbook/roles/Nagios_Plugins/tasks/additional_plugins/check_docker_overlay2_size.sh
Outdated
Show resolved
Hide resolved
…ins/tasks/additional_plugins/check_docker_overlay2_size.sh Co-authored-by: Stewart X Addison <[email protected]>
|
Done, once this is merged and rolled out via the weekly updates, I'll add the monitoring into nagios. |
sxa
approved these changes
Nov 27, 2024
...DK_Unix_Playbook/roles/Nagios_Plugins/tasks/additional_plugins/check_docker_overlay2_size.sh
Outdated
Show resolved
Hide resolved
| fi | ||
|
|
||
| # Convert size to GB for display | ||
| FOLDER_SIZE_GB=$(echo "scale=2; $FOLDER_SIZE_BYTES / (1024 * 1024 * 1024)" | bc) |
There was a problem hiding this comment.
You don't see bc used often enough these days ;-)
There was a problem hiding this comment.
I based it on an existing script, but I wanted the parameters to be simple, rather than in bytes/kilobytes/megabytes :)
| FOLDER_SIZE_GB=$(echo "scale=2; $FOLDER_SIZE_BYTES / (1024 * 1024 * 1024)" | bc) | ||
|
|
||
| # Determine Nagios status | ||
| if (( FOLDER_SIZE_BYTES > CRIT_THRESHOLD_BYTES )); then |
There was a problem hiding this comment.
I was thinking that this needed $ prefxes but apparently not.
Also noting that while these two numbers are calculated within the script, this syntax prevents the issues described in https://yossarian.net/til/post/some-surprising-code-execution-sources-in-bash/ with using -gt and similar constructs, which is giong to take a bit of getting used to
…ins/tasks/additional_plugins/check_docker_overlay2_size.sh Co-authored-by: Stewart X Addison <[email protected]>
andrew-m-leonard
approved these changes
Nov 27, 2024
mahdipub
pushed a commit
to mahdipub/infrastructure
that referenced
this pull request
Dec 5, 2024
) * UnixPB: Add Docker Overlay Check Script For Nagios * Update ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Nagios_Plugins/tasks/additional_plugins/check_docker_overlay2_size.sh Co-authored-by: Stewart X Addison <[email protected]> * Update ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/Nagios_Plugins/tasks/additional_plugins/check_docker_overlay2_size.sh Co-authored-by: Stewart X Addison <[email protected]> --------- Co-authored-by: Stewart X Addison <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #3797
Add a new script to be used by nagios for monitoring the size of the /var/lib/docker/overlay2 folder, and ensure it is installed alongside the other nagios plugins.
Checklist
VPC OK : https://ci.adoptium.net/job/VagrantPlaybookCheck/2008/