Fix issue 3577 #3732
Fix issue 3577 #3732
Conversation
|
✔️ VPC / Ubuntu 24 / JDK21 / https://ci.adoptium.net/job/SFR-VPC-AZURE-POC/OS=Ubuntu2404,label=vagrant/72/ |
There was a problem hiding this comment.
One line comment fix :-)
What is the history of the nasm patch? I was initally concerned about provenance / SBoM content but nasm is only used for OpenJ9 AFAIK. Is there a newer version of nasm that has the fix needed here? I guess our other option would be to skip it on Ubuntu 24.04 ...
It's from NASM themselves, its in later versions of NASM.. netwide-assembler/nasm@5eb1838 & netwide-assembler/nasm@53371dd .. Im happy to skip on Ubuntu 24 if you'd rather? .. It is fixed in later versions though. |
|
Bug fix for nasm: https://bugzilla.nasm.us/show_bug.cgi?id=3392461 |
The real question is whether it's worth upgrading nasm. @pshipton @AdamBrousseau Any thoughts on this? Let's hold off until we hear back on this. |
|
OpenJ9 isn't planning to build on Ubuntu 24_04, although I suppose a developer might want to, as long as they don't want to run the resulting JVM elsewhere. I don't see an issue installing a newer nasm version on this platform. The OpenJ9 build instructions specify v2.13.03 or newer. There are some other OpenJ9 issues trying to compile on 24_04 atm, although they should be fixed within the next week or so. |
Thanks @pshipton , I'll bump NASM to the current stable release 2.16.03 :) |
sxa
dismissed
their stale review
Will be unavailable for the next 3 days and we have an alternate solution that will be impemented in this PR
steelhead31
force-pushed
the
fix_issue_3577
branch
from
2245c07 to
c3bdf7e
Compare
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/nasm/tasks/main.yml
Outdated
Show resolved
Hide resolved
Linter Fix Linter fix VPC: Fix whitespace VPC: Bump NASM to 2.16.03 This removes the need for a patch to support gcc > 7.5 Co-Authored-By: Martijn Verburg <[email protected]> Co-Authored-By: Stewart X Addison <[email protected]>
steelhead31
force-pushed
the
fix_issue_3577
branch
from
137a39a to
b4ade61
Compare
Fixes #3577
Adds Ubuntu 24.04 support to the Vagrant playbook check process.
Required changes to compiling NASM on Ubuntu 24.04
Also a change to the VPC build tests to build using the devkit, rather than gcc 7.5.
Checklist