Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Fix latest linter errors #3616

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Jun 24, 2024

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Using warn: False/warn=False is deprecated, which is causing linter errors
FAILED! => {"changed": false, "msg": "Unsupported parameters for (ansible.legacy.command) module: warn. Supported parameters include: _raw_params, _uses_shell, argv, chdir, creates, executable, removes, stdin, stdin_add_newline, strip_empty_ends."}

inline-env-var: Command module does not accept setting environment variables inline.
ansible/playbooks/AdoptOpenJDK_AIX_Playbook/roles/yum/tasks/main.yml:70 Task/Handler: Unpack yum bundle

inline-env-var: Command module does not accept setting environment variables inline.
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/ccache/tasks/main.yml:17 Task/Handler: Download ccache.tar.gz

For the aix yum task, the yum role is deprecated. We install dnf on 7.2+ so I am comfortable removing the warn option there. For the ccache role, running the task without the warn makes no difference to the output, so i've removed it for that task

@Haroon-Khel Haroon-Khel changed the title Fix latest linter errors github: Fix latest linter errors Jun 24, 2024
@Haroon-Khel Haroon-Khel requested a review from steelhead31 June 25, 2024 09:19
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams gdams merged commit f0cc1a3 into adoptium:master Jun 25, 2024
12 checks passed
@Haroon-Khel Haroon-Khel deleted the linter.fix branch June 25, 2024 10:28
aswinkr77 pushed a commit to aswinkr77/infrastructure that referenced this pull request Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants