-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: Add ubi9 docker static dockerfile #3592
Conversation
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/DockerStatic/Dockerfiles/Dockerfile.ubi9
Outdated
Show resolved
Hide resolved
Also can we change the commit message to indicate that this is a static dockerfile to distinguish it from a build one please? |
ansible/playbooks/AdoptOpenJDK_Unix_Playbook/roles/DockerStatic/Dockerfiles/Dockerfile.ubi9
Outdated
Show resolved
Hide resolved
Noting also that the UBI8 file (which this ubi9 one is based on) also has similar "features" to the ones mentioned in my review. @steelhead31 Do you recall why |
Nope, I can't recall , it will have been something to do with a missing dependency or build from source of some kind, but its possibly redundant now. Id say remove it , and see if we encounter any other issues as a reminder. |
db2a5b1
to
faf1d9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* docker: Add ubi9 docker static dockerfile * change yum to dnf, remove libnss3.so
ref #3586