Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Add ubi9 docker static dockerfile #3592

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Jun 11, 2024

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref #3586

@sxa
Copy link
Member

sxa commented Jun 12, 2024

Also can we change the commit message to indicate that this is a static dockerfile to distinguish it from a build one please?

@sxa
Copy link
Member

sxa commented Jun 12, 2024

Noting also that the UBI8 file (which this ubi9 one is based on) also has similar "features" to the ones mentioned in my review.

@steelhead31 Do you recall why libnss3.so was passed to yum in this dockerfile? (Ref: #3169) It looks like that doesn't work on UBI8 either - it's also in the playbooks for RPM-based distributions, although I haven't yet found any it'll work on on aarch64.

@steelhead31
Copy link
Contributor

Noting also that the UBI8 file (which this ubi9 one is based on) also has similar "features" to the ones mentioned in my review.

@steelhead31 Do you recall why libnss3.so was passed to yum in this dockerfile? (Ref: #3169) It looks like that doesn't work on UBI8 either - it's also in the playbooks for RPM-based distributions, although I haven't yet found any it'll work on on aarch64.

Nope, I can't recall , it will have been something to do with a missing dependency or build from source of some kind, but its possibly redundant now. Id say remove it , and see if we encounter any other issues as a reminder.

@Haroon-Khel Haroon-Khel changed the title docker: Add ubi9 dockerfile docker: Add ubi9 docker static dockerfile Jun 12, 2024
@Haroon-Khel Haroon-Khel requested a review from sxa June 12, 2024 11:58
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haroon-Khel Haroon-Khel merged commit e6d776a into adoptium:master Jun 12, 2024
17 of 18 checks passed
@Haroon-Khel Haroon-Khel deleted the ubi9.dockerstatic branch June 12, 2024 16:01
aswinkr77 pushed a commit to aswinkr77/infrastructure that referenced this pull request Jun 27, 2024
* docker: Add ubi9 docker static dockerfile

* change yum to dnf, remove libnss3.so
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants