Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dev.system test_dir and remove docker label for dev.system #956

Merged
merged 3 commits into from
Mar 5, 2024

Conversation

sophia-guo
Copy link
Contributor

@sophia-guo sophia-guo commented Mar 4, 2024

Fix adoptium/temurin-build#3674

also remove docker requirement for dev.system as this is not required for reproducible comparing tests.

Current test_dirs(VENDOR_DIRS) supports multi dirs separated by comma. However that is multi dir strings for multi Vendor_repos. That is one test_dir for one vendor_repo. So we can't do this by set default test_dirs to "/test/functional, /test/system" in defaults.jason.

Signed-off-by: Sophia Guo <[email protected]>
Copy link

github-actions bot commented Mar 4, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@sophia-guo
Copy link
Contributor Author

@sophia-guo sophia-guo requested a review from smlambert March 4, 2024 18:52
@sophia-guo sophia-guo changed the title Set dev.system test_dir Set dev.system test_dir and remove docker label for dev.system Mar 4, 2024
@github-actions github-actions bot added the docker label Mar 5, 2024
@karianna karianna merged commit 3f4d0de into adoptium:master Mar 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReproducibleCompare tests won't be triggered as dev.system
3 participants