Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable regular nightly and weekly build for jdk21 #826

Closed
wants to merge 1 commit into from

Conversation

sophia-guo
Copy link
Contributor

Signed-off-by: Sophia Guo [email protected]

@sophia-guo sophia-guo marked this pull request as draft October 10, 2023 16:34
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@sophia-guo
Copy link
Contributor Author

@andrew-m-leonard is it a good time to enable the regular nightly and weekly build for jdk21?

@sxa
Copy link
Member

sxa commented Oct 10, 2023

I believe the intention is to only use the trigger job going forward - there should be no need to have this running on a more regular cadence, since it will be triggered with all applicable jobs on each new tag appearing.

Also at the moment (while we don't have a JDK21 GA on all platforms) we need to avoid publishing new nightlies for JDK21 so that the EA level that we've been pointing people at is still the one based off jdk-21+35.

@andrew-m-leonard
Copy link
Contributor

andrew-m-leonard commented Oct 12, 2023

@andrew-m-leonard is it a good time to enable the regular nightly and weekly build for jdk21?

As per @sxa comment.
The jdk21u EA builds will trigger from here https://ci.adoptium.net/job/build-scripts/job/utils/job/releaseTrigger_21ea/
which is currently disabled as per Stewart's comment

@sxa
Copy link
Member

sxa commented Oct 12, 2023

Having said that I do now have a concern that with no new tags being created in jdk21u perhaps there is justification for having this on some regular basis for jdk21u specifically (maybe just the weekly) but perhaps without publishing

@andrew-m-leonard
Copy link
Contributor

Yeah, until Oracle hand over jdk-21.0.2 to SAP in January there will be no regular build tags, and jdk1u will contain a mix of jdk-21.0.1 and 21.0.2 commits

@sophia-guo sophia-guo self-assigned this Nov 2, 2023
@sophia-guo
Copy link
Contributor Author

Dup of #834. Close it.

@sophia-guo sophia-guo closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants