Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JMOD signing retry and check curl rc #823

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

andrew-m-leonard
Copy link
Contributor

Add retry to the JMOD Windows&Mac signing, as a workaround until EF upstream issue is resolved: https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3758
This is likely to fail during the release builds with the current failure rate.

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we wrap this in a flag or comment what we should revert later?

@andrew-m-leonard
Copy link
Contributor Author

Can we wrap this in a flag or comment what we should revert later?

I think having an issue is probably best as this retry logic is in multiple places/repos, raised adoptium/temurin-build#3496

@andrew-m-leonard
Copy link
Contributor Author

run tests

@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

✅ All pipelines passed! ✅

@karianna karianna merged commit 16502bc into adoptium:master Oct 5, 2023
7 checks passed
andrew-m-leonard added a commit that referenced this pull request Oct 9, 2023
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants