Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daily build health stats exclude -ga from upstream tag search #821

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Daily build health stats exclude -ga from upstream tag search #821

merged 2 commits into from
Sep 27, 2023

Conversation

andrew-m-leonard
Copy link
Contributor

Fix incorrect latest upstream openjdk tag check due to "-ga" tag:

Latest Adoptium publish binaries jdk-21+35-ea-beta !=  latest upstream openjdk build jdk-21-ga-ea-beta.

@andrew-m-leonard andrew-m-leonard self-assigned this Sep 27, 2023
@github-actions github-actions bot added the code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts label Sep 27, 2023
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@github-actions github-actions bot added testing and removed testing labels Sep 27, 2023
@andrew-m-leonard andrew-m-leonard changed the title Exclude -ga from upstream tag search Daily health stats exclude -ga from upstream tag search Sep 27, 2023
@andrew-m-leonard andrew-m-leonard changed the title Daily health stats exclude -ga from upstream tag search Daily build health stats exclude -ga from upstream tag search Sep 27, 2023
steelhead31
steelhead31 approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna merged commit ab12412 into adoptium:master Sep 27, 2023
6 checks passed
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
@andrew-m-leonard @luhenry
Daily build health stats exclude -ga from upstream tag search (adopti…
e70730b 
…um#821)

* Exclude -ga from upstream tag search

Signed-off-by: Andrew Leonard <[email protected]>

* Exclude -ga from upstream tag search

Signed-off-by: Andrew Leonard <[email protected]>

---------

Signed-off-by: Andrew Leonard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steelhead31 steelhead31 steelhead31 approved these changes

@karianna karianna karianna approved these changes

@sxa sxa Awaiting requested review from sxa

Assignees

@andrew-m-leonard andrew-m-leonard

Labels
code-tools Issues that are miscellaneous enhancements or bugs with our utilities that assist our build scripts testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrew-m-leonard @karianna @steelhead31