Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide Windows SDK UCRT DLL paths for jdk17+ pipeline configuration #811

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Provide Windows SDK UCRT DLL paths for jdk17+ pipeline configuration #811

merged 3 commits into from
Sep 12, 2023

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Sep 11, 2023 •
edited
Loading

To ensure a managed and thus deterministic Windows SDK DLLs for jdk-17+ JDKs, specify --with-ucrt-dll-dir=.

The standard Windows SDK version 10.0.22000.0 UCRT DLLs used with VS2019 are located in:

'C:/progra~2/wi3cf2~1/10/Redist/10.0.22000.0/ucrt/DLLs/x64'

Fixes adoptium/temurin-build#3479

@andrew-m-leonard andrew-m-leonard self-assigned this Sep 11, 2023
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@andrew-m-leonard
Copy link
Contributor Author

run tests

@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

steelhead31
steelhead31 approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna
Copy link
Contributor

run tests

@github-actions github-actions bot added the x64 Issues that affect or relate to the x64/x32 LINUX OS label Sep 12, 2023
@eclipse-temurin-bot
Copy link
Collaborator

 PR TESTER RESULT 

✅ All pipelines passed! ✅

@andrew-m-leonard andrew-m-leonard merged commit a6f9194 into adoptium:master Sep 12, 2023
7 checks passed
AdamBrousseau added a commit to AdamBrousseau/ci-jenkins-pipelines that referenced this pull request Sep 22, 2023
@AdamBrousseau
Do not hardcode ucrt dll location for Semeru
034f9a6 
Related adoptium#811 runtimes infra 8378

Signed-off-by: Adam Brousseau <[email protected]>
@AdamBrousseau AdamBrousseau mentioned this pull request Sep 22, 2023
Merged
luhenry pushed a commit to luhenry/adoptium-ci-jenkins-pipelines that referenced this pull request Feb 3, 2024
@andrew-m-leonard @luhenry
Provide Windows SDK UCRT DLL paths for jdk17+ pipeline configuration (a…
6b07390 
…doptium#811)

* Add jdk17+ pipeline configuration for --with-ucrt-dll-dir location and version

Signed-off-by: Andrew Leonard <[email protected]>

* Add jdk17+ pipeline configuration for --with-ucrt-dll-dir location and version

Signed-off-by: Andrew Leonard <[email protected]>

* Add jdk17+ pipeline configuration for --with-ucrt-dll-dir location and version

Signed-off-by: Andrew Leonard <[email protected]>

---------

Signed-off-by: Andrew Leonard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steelhead31 steelhead31 steelhead31 approved these changes

@karianna karianna karianna approved these changes

Assignees

@andrew-m-leonard andrew-m-leonard

Labels
jenkins-pipeline x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows UCRT Redist DLL version is not deterministic
4 participants
@andrew-m-leonard @eclipse-temurin-bot @karianna @steelhead31