switch windows builds to use docker image from azurecr #1170
Conversation
Signed-off-by: Stewart X Addison <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
|
It doesn't look like we're going to have any EA builds tonight (no new tags) so I'll kick off a full set of tests to verify that the regeneration works ok with these parameters which haven't been used in our CI previously. |
|
run tests |
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
|
Shame on both reviewers for not spotting the typo ;-) |
|
run tests |
|
On a separte note ... Grrr @ BlueOcean for not showing the windows blob as "red" https://ci.adoptium.net/blue/organizations/jenkins/build-scripts-pr-tester%2Fbuild-test%2Fopenjdk21-pipeline/detail/openjdk21-pipeline/86/pipeline |
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
|
Latest set of tests seemed to still be trying to pull |
|
run tests |
PR TESTER RESULT ✅ All pipelines passed! ✅ |
Currently the windows container builds are using a local container image on the machine which is not scalable and takes a while to update. This change will pull from the private azure container registry with a credential where we are storing the container images.
Partially fixes adoptium/infrastructure#3217 (For Windows only)
Related adoptium/infrastructure#3780 which is required to keep the image up to date with the playbooks
Related: The docker file used for creating this image is https://github.com/adoptium/infrastructure/blob/master/ansible/docker/Dockerfile.win2022
Also for reviewers: I'd much rather rename this credential prior to making this live since it might get mistaken for an actual credential (It's not - it's the ID/label in our jenkins instance of the stored credential)
Also FYI @AdamBrousseau for awareness. This is likely the final step in making our Windows Temurin builds run as well as they can in containers, and make it consistent with the Linux builds.