x86 Redist API-MS-Win DLLs not being skipped during Eclipse signing

[andrew-m-leonard]

x86 Redist DLLs have an upper case file with "API-MS-Win" :

https://ci.adoptium.net/job/build-scripts/job/release/job/sign_verification/2234/console

FAILURE: The following 3 executables are not signed correctly:
    unpacked/jdk/expanded_java.base.jmod/lib/API-MS-Win-core-xstate-l2-1-0.dll
    unpacked/jdk/jdk-17.0.14+6/bin/API-MS-Win-core-xstate-l2-1-0.dll
    unpacked/jre/jdk-17.0.14+6-jre/bin/API-MS-Win-core-xstate-l2-1-0.dll

[github-actions]

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

[andrew-m-leonard]

run tests

[adamfarley]

LGTM

[eclipse-temurin-bot]

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[karianna]

run tests

[eclipse-temurin-bot]

 PR TESTER RESULT 

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

[adamfarley]

FYI: The pipeline-build-check appears to have passed on all platforms except Windows.

On Windows, we see 4 instances (JDK 8, 11, 17, 21) of our old friend:

22:16:34  C:\workspace\openjdk-build>git clean -fdx 
22:16:34  warning: failed to remove workspace/: Permission denied

This is a known Windows Docker bug which is not related to this issue.

However, since this is a dll issue, it'd be good to run some windows builds, so I've rerun the JDK8 build on a non-docker machine.

https://ci.adoptium.net/job/build-scripts-pr-tester/job/build-test/job/jobs/job/jdk8u/job/jdk8u-windows-x64-temurin/213/

Addendum: On closer inspection, JDK 8, 11, and 17 failed with that error, but JDK21 successfully completed the build before failing with a different error. Permission denied, etc etc.