-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For jdk8u aarch32|alpine beta triggers check for existance of a specific asset #1153
For jdk8u aarch32|alpine beta triggers check for existance of a specific asset #1153
Conversation
… exist Signed-off-by: Andrew Leonard <[email protected]>
… exist Signed-off-by: Andrew Leonard <[email protected]>
… exist Signed-off-by: Andrew Leonard <[email protected]>
… exist Signed-off-by: Andrew Leonard <[email protected]>
… exist Signed-off-by: Andrew Leonard <[email protected]>
… exist Signed-off-by: Andrew Leonard <[email protected]>
… exist Signed-off-by: Andrew Leonard <[email protected]>
… exist Signed-off-by: Andrew Leonard <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
… exist Signed-off-by: Andrew Leonard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linter requests 2 changes. Thoughts?
… exist Signed-off-by: Andrew Leonard <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Fixes #1152
Update trigger_beta_build.groovy to check for the existence of a specific asset rather than rely purely on the release tag existing.
Also prevent evaluation pipelines incorrectly triggering for jdk8u_aarch32 and jdk8u_alpine.
Note: This change will imply that if the given "arch" above is failing to build, then repeat triggers can occur in that scenario, but then there's obviously a build problem anyway...