Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For jdk8u aarch32|alpine beta triggers check for existance of a specific asset #1153

Merged
merged 10 commits into from
Dec 2, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Dec 2, 2024

Fixes #1152

Update trigger_beta_build.groovy to check for the existence of a specific asset rather than rely purely on the release tag existing.

  • x64_linux : Main versions
  • arm_linux : jdk8u_aarch32
  • x64_alpine-linux : jdk8u_x64_alpine

Also prevent evaluation pipelines incorrectly triggering for jdk8u_aarch32 and jdk8u_alpine.

Note: This change will imply that if the given "arch" above is failing to build, then repeat triggers can occur in that scenario, but then there's obviously a build problem anyway...

@andrew-m-leonard andrew-m-leonard self-assigned this Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@github-actions github-actions bot added arm linux x64 Issues that affect or relate to the x64/x32 LINUX OS labels Dec 2, 2024
Copy link
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter requests 2 changes. Thoughts?

Copy link
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andrew-m-leonard andrew-m-leonard merged commit 562ec67 into adoptium:master Dec 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch alpine-linux arm jenkins-pipeline linux x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

betaTrigger_8ea_arm32Linux does not trigger arm32 build if jdk8u main pipeline has already published
3 participants