Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mac signing: Stash all files again but with exclusions #1139

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Nov 11, 2024

Fixes the errors we're seeing at the moment introduced by #1117 - mac executables are not being signed as they were not being included in the stash as they don't have a suffix. Slack thread

The exclude list here is from files that were causing the signed stash to fail to be extracted.

15:53:28 Caused by: java.nio.file.AccessDeniedException: /Users/admin/workspace/workspace/build-scripts/jobs/jdk21u/windbld/workspace/build/src/build/macosx-aarch64-server-release/support/modules_libs/java.base/security/public_suffix_list.dat
16:27:43 Caused by: java.nio.file.AccessDeniedException: /Users/admin/workspace/workspace/build-scripts/jobs/jdk21u/windbld/workspace/build/src/build/macosx-aarch64-server-release/support/modules_libs/java.desktop/fontconfig.bfc

@sxa sxa added the mac label Nov 11, 2024
@sxa sxa requested a review from andrew-m-leonard November 11, 2024 17:33
@sxa sxa self-assigned this Nov 11, 2024
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@sxa
Copy link
Member Author

sxa commented Nov 11, 2024

Note: I still want to revisit this and try and reduce the amount of files which is stashes sine this does increase the amount of time and data that's being thrown across the network unneccesarily, but we can do that later in the interests if keeping the builds working.

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sxa sxa merged commit b6ea304 into adoptium:master Nov 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants