-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Trial using context.bat
instead of context.sh
on Windows in docker
#1103
Conversation
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Signed-off-by: Stewart X Addison <[email protected]>
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
Signed-off-by: Stewart X Addison <[email protected]>
cce3768
to
3ef6092
Compare
7773e9a
to
99a9cdf
Compare
Signed-off-by: Stewart X Addison <[email protected]>
3ec7169
to
61b2efd
Compare
61b2efd
to
ecbb95e
Compare
Signed-off-by: Stewart X Addison <[email protected]>
98ed8f0
to
3107b76
Compare
Will be integrated into #1117 |
This is very much a 'work-in-progress' / feasibility study with the intention of diagnosing the problem described in adoptium/infrastructure#3714. The PR is not ready for review (since it's mostly debug information and experiments) but I'm creating it in the spirit of openness to go alongside the issue :-)
I have attempted to put comments against all of the
context.sh
operations which are performed inside the containers during a docker build to identify which ones are causing problems.I have converted some of them to
context.bat
based on some of the trial runs (Noting that this cannot be a final solution as-is as it won't work on non-Windows systems unless anif windows
block is used to switch between them).The four-digit numbers in the
battable
lines are the line number in theopenjdk_build_pipeline.groovy
and thewindbld
numbers are the job runs of windbld which showed the problem, so are instances where we have definitely hit an issue with those.