Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform a "bootstrap" DevKit build to ensure final DevKit dependencies are built with identical gcc #1014

Merged
merged 5 commits into from
May 10, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

Fixes #1008

Performs an initial DevKit build using the environment gcc, then builds the "final" DevKit using the gcc toolchain from the bootstrap DevKit

@andrew-m-leonard andrew-m-leonard self-assigned this Apr 22, 2024
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,21"

@andrew-m-leonard
Copy link
Contributor Author

Adding this arbitrary comment to see if it triggers code-freeze!!?!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Apr 24, 2024

Adding this arbitrary comment to see if it triggers code-freeze!!?!

and yes it does!

@andrew-m-leonard
Copy link
Contributor Author

/thaw

@github-actions github-actions bot dismissed their stale review May 9, 2024 15:17

Pull Request unblocked - code freeze is over.

Copy link
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-m-leonard andrew-m-leonard merged commit b5f07cd into adoptium:master May 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adoptium DevKit is not reproducible with a 3rd party built DevKit due to library dynsym order differences
3 participants