Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Grinder link to properly rerun with 0 iterations and always rerun with parallel=none #5829

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

jiekang
Copy link
Contributor

@jiekang jiekang commented Dec 16, 2024

Fixes: #4830

This adjusts the code when generating grinder link parameters to:

  • always rerun with 0 iterations
  • never use lightweight checkouts
  • always use no parallelization

with slightly refactored code that should be easier to read.

@sophia-guo
Copy link
Contributor

Grinder - RERUN_ITERATIONS=1, PARALLEL=dynamic https://ci.adoptium.net/job/Grinder/12128/

generated rerun links with RERUN_ITERATIONS=0 PARALLEL=None, LIGHT_WEIGHT_CHECKOUT=false as expected.

Rerun in Grinder Change TARGET to run only the failed test targets.
Rerun in Grinder on same machine Change TARGET to run only the failed test targets. For dynamic vm agents as they are created at runtime and quickly recycled, it may not be possible to rerun on the same agent.
Rerun in Grinder with failed test targets
Rerun failed jdk test cases in Grinder with jdk_custom target, rerun failed test link, rerun jdk_custom link a

@sophia-guo sophia-guo marked this pull request as ready for review December 17, 2024 21:38
@karianna karianna merged commit a13373a into adoptium:master Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rerun failed openjdk tests with jdk_custom | hotspot_custon link should force set PARALLEL=None
3 participants