JDK 24+ don't enable security manager and disable failing tests #5817
+299
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
force-pushed
the
system_secmanager
branch
from
ced9f92 to
242b0dd
Compare
|
The remaining failures are due to use of the SecurityManager library in the system test framework. I opened adoptium/STF#142 and will temporarily disable the failing tests. |
theresa-m
force-pushed
the
system_secmanager
branch
5 times, most recently
from
3769dc2 to
cd8c92e
Compare
theresa-m
changed the title
|
This is ready for review fyi @llxia |
pshipton
requested changes
Dec 17, 2024
system/system.mk
Outdated
| @@ -47,14 +47,15 @@ else | |||
| OPENJ9_PRAM="" | |||
| endif | |||
|
|
|||
| # In JDK 24+ any attempts to enable the security manager will result in an error | |||
There was a problem hiding this comment.
This sentence is missing a period.
Signed-off-by: Theresa Mammarella <[email protected]>
…from framework Signed-off-by: Theresa Mammarella <[email protected]>
…d from framework Signed-off-by: Theresa Mammarella <[email protected]>
theresa-m
force-pushed
the
system_secmanager
branch
from
cd8c92e to
c4d631b
Compare
pshipton
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JEP 486 for Java 24 any attempt to enable a security manager (such as -Djava.security.manager=allow) will result in an error. This change removes the use of java.security.manager=allow from JDK 24+.
The system test framework also has uses the security manager for load tests that needs to be removed. In the meantime this change disables tests that are failing because of it. See adoptium/STF#142