Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk: Add hotspot tier1 targets #5648

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Conversation

zzambers
Copy link
Contributor

This adds hotspot tier1 targets. They only run limited set of tests from each group, without long running tests. Having these targets is usefull to be able to run tier1 style testing using aqa targets.
(They may potentially be ran as part of sanity.openjdk)

Testing:
jdk 21 / x86-64_linux
hotspot_tier1_compiler: OK
hotspot_tier1_runtime: OK
hotspot_tier1_gc: OK
hotspot_tier1_serviceability: OK
hotspot_tier1_common: 8 FAILURES

gtest/GTestWrapper.java.GTestWrapper
gtest/LargePageGtests.java#use-large-pages-1G.LargePageGtests_use-large-pages-1G
gtest/LargePageGtests.java#use-large-pages-sysV.LargePageGtests_use-large-pages-sysV
gtest/LargePageGtests.java#use-large-pages.LargePageGtests_use-large-pages
gtest/MetaspaceGtests.java#balanced-no-ccs.MetaspaceGtests_balanced-no-ccs
gtest/NMTGtests.java#nmt-detail.NMTGtests_nmt-detail
gtest/NMTGtests.java#nmt-off.NMTGtests_nmt-off
gtest/NMTGtests.java#nmt-summary.NMTGtests_nmt-summary

All targets but hotspot_tier1_common are basically subsets of existing hotspot targets, so no surprises were expected there. However hotspot_tier1_common shows failures of gtest tests. Seems like these are not supported yet in adoptium.

@zzambers
Copy link
Contributor Author

Filled issue for gtest problem: adoptium/temurin-build#3956

@karianna karianna requested a review from smlambert September 26, 2024 08:41
@smlambert
Copy link
Contributor

@zzambers
Copy link
Contributor Author

zzambers commented Oct 1, 2024

I have disabled hotspot_tier1_common for now, as it requires gtest support.

@smlambert smlambert merged commit ff1342d into adoptium:master Oct 1, 2024
3 checks passed
@andrew-m-leonard
Copy link
Contributor

I'm finding several tests that are failing on Windows from hotspot_tier1_runtime_0 and hotspot_tier1_serviceability_0,
i've tried running them numerous times on several nodes as part of : adoptium/ci-jenkins-pipelines#1104 (comment)

I suspect they will need excluding, maybe worth analysing to exclude before next week's release, as it's quite time consuming triaging them.

I shall try and get a list of the failing tests.

@andrew-m-leonard
Copy link
Contributor

Raised: #5671

@andrew-m-leonard
Copy link
Contributor

Raised: #5672

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants