[v1.0.0-release]: Add version and tag to JDK_BRANCH #4957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smlambert
reviewed
Jan 11, 2024
smlambert
reviewed
Jan 11, 2024
There was a problem hiding this comment.
@Haroon-Khel - can you also update the prefixes as per the suggestions? While they are currently 'not in use', they will be soon, and it will be useful to be able to use this branch for testing the new mechanism.
smlambert
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should have gone in with #4953
Should the JDKXX_BRANCH_PREFIX and JDKXX_BRANCH be the same? If so whats the purpose of JDKXX_BRANCH_PREFIX?
Im seeing this on the dry run builds for jdk 8 11 and 17, https://ci.adoptium.net/job/build-scripts/job/release-openjdk8-pipeline/34/console
I think this should work