Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Skynet exclude naming #4368

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Fix Skynet exclude naming #4368

merged 1 commit into from
Feb 27, 2023

Conversation

fengxue-IS
Copy link
Contributor

Addresses #4354 (comment)

Signed-off-by: Jack Lu [email protected]

@fengxue-IS
Copy link
Contributor Author

x86 grinder run 862 tests, nightly build without this change have 863 tests run on x86

@llxia
Copy link
Contributor

llxia commented Feb 27, 2023

Just for future reference, if we set KEEP_REPORTDIR to true in Grinder, we can see subtests details. For example, internal job link.

llxia
llxia approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 032549e into adoptium:master Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fengxue-IS @llxia @karianna