Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2726

Closed
wants to merge 1 commit into from
Closed

Conversation

Ayushdubey86
Copy link

@Ayushdubey86 Ayushdubey86 commented Jul 10, 2021

This solves the issue of #2725

@Ayushdubey86
Copy link
Author

Ayushdubey86 commented Jul 10, 2021

This helps in making sure English is better of README

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ayushdubey86 - I appreciate your desire to help the project, but this does not significantly improve the documentation. I will close this PR without merging. If you are interested in making a different contribution, please take a look at the "good first issues" list here: https://github.com/orgs/adoptium/projects/2

@@ -71,10 +70,10 @@ We want:

There are a great number of tests available to test a JVM, starting with the OpenJDK regression tests. In addition to running the OpenJDK regression tests, we will increase the amount of testing and coverage by pulling in other open tests. These new tests are not necessarily written using the jtreg format.

Why the need for other testing? The OpenJDK regression tests are a great start, but eventually you may want to be able to test how performant is your code, and whether some 3rd party applications still work. We will begin to incorporate more types of testing, including:
Why the need for another testing? The OpenJDK regression tests are a great start, but eventually, you may want to be able to test how performant is your code, and whether some 3rd party applications still work. We will begin to incorporate more types of testing, including:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change does not improve this sentence. It is more correct to say "why the need for other testing" than it is to say "why the need for another testing".

@@ -55,8 +55,7 @@ Functional tests not originating from the openjdk regression suite, that include
---

##### jck tests - Compliance tests
TCK tests (under the OpenJDK Community TCK License Agreement), in compliance with the license agreement. While this test material is currently not run at the Adoptium project (see the [support statement](https://adoptopenjdk.net/support.html#jck) for details), those with their own OCTLA agreements may use the Adoptium test automation infrastructure to execute their TCK test material in their own private Jenkins servers.

TCK tests (under the OpenJDK Community TCK License Agreement), in compliance with the license agreement. While this test material is currently not run at the Adoptium project (see the support statement for details), those with their OCTLA agreements may use the Adoptium test automation infrastructure to execute their TCK test material on their own private Jenkins servers.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paragraph has not been improved with this change, the main change here is removing the hyperlink.

Since this paragraph is actually no longer true, now that we do run TCKs at the Adoptium project under the Temurin-compliance subproject, I will recommend a core committer needs to make these changes to ensure the information is accurate (which will be done under issue: #1558).

@smlambert smlambert closed this Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants