Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide banner about Eclipse Temurin 21 to be shortly released #2329

Conversation

xavierfacq
Copy link
Member

Description of change

We can now hide the banner about Eclipse Temurin 21 to be shortly released.

Checklist

  • npm test passes

@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit c9cba8a
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/6527de08ff91500008cf7126
😎 Deploy Preview https://deploy-preview-2329--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #2329 (c9cba8a) into main (a5b5473) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2329   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          87       87           
  Lines        6542     6544    +2     
  Branches      552      552           
=======================================
+ Hits         6490     6492    +2     
  Misses         52       52           
Files Coverage Δ
src/components/Banner/index.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xavierfacq xavierfacq merged commit c1bbf6b into adoptium:main Oct 12, 2023
10 checks passed
@sxa
Copy link
Member

sxa commented Oct 13, 2023

Hmmm given that we have not yet got the Linux installers available or put up information explaining the absence of some platforms I feel this should not have been removed as it guided users towards the status document.

(Also should be banner alerts rather than alert in the comment, but that's a minor point :-) )

@gdams
Copy link
Member

gdams commented Oct 13, 2023

Hmmm given that we have not yet got the Linux installers available or put up information explaining the absence of some platforms I feel this should not have been removed as it guided users towards the status document.

(Also should be banner alerts rather than alert in the comment, but that's a minor point :-) )

I think on the basis that a new banner will be up shortly for the October PSU it doesn't make much difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants