Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation support to /docs page #2286

Merged
merged 3 commits into from
Oct 5, 2023

Conversation

xavierfacq
Copy link
Member

Description of change

Add translation support to /docs page

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 8b70e6b
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/651ea1909b1a1e0008bc858b
😎 Deploy Preview https://deploy-preview-2286--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #2286 (8b70e6b) into main (bf93101) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2286   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          87       87           
  Lines        6532     6540    +8     
  Branches      552      552           
=======================================
+ Hits         6480     6488    +8     
  Misses         52       52           
Files Coverage Δ
src/components/DocumentationHeader/index.tsx 100.00% <100.00%> (ø)
src/pages/docs.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xavierfacq xavierfacq marked this pull request as ready for review October 5, 2023 09:02
@xavierfacq xavierfacq marked this pull request as draft October 5, 2023 09:05
Copy link
Member

@gdams gdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great @xavierfacq. I'll let you merge once you're happy with the final state of the PR. CC @hendrikebbers @zdtsw (it might be worth you two following up with PR's to translate these phrases too)

@xavierfacq xavierfacq marked this pull request as ready for review October 5, 2023 11:47
@xavierfacq xavierfacq merged commit fc37632 into adoptium:main Oct 5, 2023
10 checks passed
@xavierfacq xavierfacq deleted the translate_docs_page branch October 5, 2023 14:36
@zdtsw zdtsw mentioned this pull request Oct 7, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants